Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly only stream and donate in any currency #212

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

sirpy
Copy link
Contributor

@sirpy sirpy commented Jul 9, 2024

Description

  • add one time donation in all currencies (ie swap + donate)
  • remove all frequencies besides monthly
  • fix flowRate calculation for swap+stream
  • fix use public rpc for uniswap router
  • fix confirm button states according to uniswap route status (disabled, loading)
  • reduced ethers dependencies

packages/app/src/components/RoundedButton.tsx Outdated Show resolved Hide resolved
packages/app/src/components/RoundedButton.tsx Outdated Show resolved Hide resolved
toggleCompleteDonationModal(false);
toggleThankYouModal(true);
await tx.wait();
toggleIsDonationComplete(true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should he thank you modal here toggled off after the tx wait?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont know, this is how it is for other txs.
you should test the flows or ask vlad and if you think the UX should be modified open an issue

@sirpy sirpy merged commit 83da2df into master Jul 10, 2024
2 checks passed
@sirpy sirpy deleted the 203+185-monthly-and-single-swap branch July 10, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants